[PATCH] D144652: [Assignment Tracking] getIntrinsicInstrCost: set dbg.assign cost to zero

[J. Ryan Stinnett via Phabricator via llvm-commits]

jryans added a comment.

In D144652#4147834 <https://reviews.llvm.org/D144652#4147834>, @Orlando wrote:

> Note that `dbg_addr` is also missing from this list. `dbg_addr` is in the process of being removed (cc @jryans) but maybe it's worth fixing in the mean time, since it's such a tiny fix? YMMV.
>
> The result of having `dbg_addr` and `dbg_assign` missing from the list is that they're considered to cost `1` rather than `0`, which changes optimisation decisions (unrolling, peeling, inlining, etc).

I'm hoping to finish up `dbg_addr` removal this weekend (though my time estimates are nearly always too optimistic).

I guess I'd say it's not worth adding `dbg_addr` here since (a) it's almost gone and (b) it's rarely seen in wild. I am fine with either approach though, it's of course easy to remove it from here as part of my patch stack if it does get added. 🙂


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144652/new/

https://reviews.llvm.org/D144652