[PATCH] D142163: [LLD][ELF] Add --lto-export-symbol-list

[Sami Tolvanen via Phabricator via llvm-commits]

samitolvanen planned changes to this revision.
samitolvanen added inline comments.


================
Comment at: lld/ELF/LTO.cpp:262
+    bool useExports = config->ltoExportSymbols && !sym->isUsedInRegularObj &&
+                      objSym.isExecutable();
+    uint8_t binding = sym->computeBinding(useExports);
----------------
MaskRay wrote:
> `objSym.isExecutable()` this condition is strange and does not fit into the spirit that we ignore symbol types for various symbol list features.
> Can the user specify all data symbols?
I agree, this is bit awkward. I'll have to see if there's a convenient way for us to specify data symbols in the kernel. The problem is that some of these are referenced from linker scripts that are used later when linking vmlinux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142163/new/

https://reviews.llvm.org/D142163