[PATCH] D139902: IR: Add nofpclass parameter attribute

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 07:55:55 PST 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1843
+    if (const Function *F = getCalledFunction())
+      Mask |= static_cast<unsigned>(F->getAttributes().getRetNoFPClass());
+    return static_cast<FPClassTest>(Mask);
----------------
nikic wrote:
> Unrelated, but why isn't it a bitmask enum?
It should be, but there was a complication from LLVM_MARK_AS_BITMASK_ENUM not working for multiple enums in the same scope. 2e416cdd52c1079b8c7cb1f7d7e557c889a4fb56 was supposed to fix this but it was reverted. I'll clean this up whenever that's fixed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139902/new/

https://reviews.llvm.org/D139902



More information about the llvm-commits mailing list