[PATCH] D144638: [lit] Detect Consistent File Access Times

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:165
+    #
+    # This check hopefully detects both cases, and disables tests that require
+    # consistent atime.
----------------
lenary wrote:
> jhenderson wrote:
> > Is "hopefully" really needed here?
> I'm hedging in this comment, in part because we're trying to find a race condition experimentally, and also because this will cause lit to fatal error before running any tests if `touch` exits non-zero for any reason. 
if we know for sure that NetBSD and Windows don't support this, why not hardcode those values in, and only try the experimental check otherwise?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144638/new/

https://reviews.llvm.org/D144638