[PATCH] D144584: [RISCV][NFC] Reuse getDeinterleaveViaVNSRL to lower deinterleave intrinsics

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comment applied.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3478
+  if (isDeinterleaveShuffle(VT, ContainerVT, V1, V2, Mask, Subtarget) &&
+      VT.getScalarSizeInBits() < Subtarget.getELEN()) {
+    return getDeinterleaveViaVNSRL(DL, VT, V1.getOperand(0), Mask[0] == 0,
----------------
There's no point in moving this check to the caller as the isDeinterleaveShuffle routine is only being used here.  (Unless maybe you have another patch in mind, but if so, the change should probably be it's own NFC with that explained.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144584/new/

https://reviews.llvm.org/D144584