[PATCH] D144596: Add extra parameter to thinlto-prefix-replace

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/test/MachO/thinlto-index-file-object-prefix-replace.ll:3
+; RUN: rm -rf %t ; split-file %s %t && cd %t
+; RUN: mkdir -p oldpath oldpath/prefix_replace
+
----------------
This needs to go under `%t` (otherwise the tests may fail in our integrates because only stuff under `%t` is writeable)


================
Comment at: lld/test/MachO/thinlto-index-file-object-prefix-replace.ll:5
+
+; RUN: opt -module-summary f.ll -o oldpath/prefix_replace/1.o
+; RUN: opt -module-summary g.ll -o oldpath/prefix_replace/2.o
----------------
`%t/oldpath`

(here and the rest)


================
Comment at: lld/test/MachO/thinlto-index-file-object-prefix-replace.ll:10
+;; Ensure lld writes linked files to linked objects file
+; RUN: ld.lld --thinlto-index-only=1.txt -shared oldpath/prefix_replace/1.o oldpath/prefix_replace/2.o oldpath/3.o -o /dev/null
+; RUN: ls oldpath/prefix_replace/1.o.thinlto.bc
----------------
This is running with the ELF port? 
You should use the variable `%lld`  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144596/new/

https://reviews.llvm.org/D144596