[PATCH] D137091: [llvm-readobj] Rename JSON Flag fields to be more consistent

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 00:56:38 PST 2023


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one caveat: has there been an LLVM release which produced the old name in a usable form? If so, this probably needs a release note. If on the other hand, the JSON would have been invalid, or the name wasn't emitted at all, there's no need to change anything.

Sorry for taking so long to get back around to this patch series. Is there a particular one you'd like me to look at as a priority? I'll otherwise aim to do 1 or 2 a day, depending on my other work and review load.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137091/new/

https://reviews.llvm.org/D137091



More information about the llvm-commits mailing list