[PATCH] D144353: [lld][RISCV] Avoid error when encountering unrecognised ISA extensions/versions in RISC-V attributes

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 23:56:23 PST 2023


kito-cheng added a comment.

LGTM

I like the idea which decoupling the parsing logic of the normal march string parsing, and we can have a simple parser logic here since ELF attribute has specified that should have explicitly version number and separated by `_`.

This also enable us could implement further complicated merge rule like merging unknown extension, different extension version and unsupported extension version - not just limited to handle knowing extension and supported version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144353/new/

https://reviews.llvm.org/D144353



More information about the llvm-commits mailing list