[PATCH] D144565: dwp check overflow

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added a comment.

I didn't see any tests in the PR. Please add one.



================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:471-472
+      if (Overflow) {
+        std::string SectionName = SectionPair->first().str();
+        return make_error<DWPError>(
+            std::string("Section size overflow in " + SectionName));
----------------
("Section size overflow in " + SectionPair->first()).str() ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144565/new/

https://reviews.llvm.org/D144565