[PATCH] D144612: [AMDGPU] Move V_FMA_MIX pattern matching into tablegen. NFC
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 22 18:06:03 PST 2023
arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:548-552
- const SIMachineFunctionInfo *MFI =
- I.getMF()->getInfo<SIMachineFunctionInfo>();
- AMDGPU::SIModeRegisterDefaults Mode = MFI->getMode();
- assert((IsFMA || !Mode.allFP32Denormals()) &&
- "fmad selected with denormals enabled");
----------------
This is losing the assert but this probably shouldn't be an assert in the first place, maybe could be a verifier check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144612/new/
https://reviews.llvm.org/D144612
More information about the llvm-commits
mailing list