[PATCH] D144353: [lld][RISCV] Avoid error when encountering unrecognised ISA extensions/versions in RISC-V attributes

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 14:44:07 PST 2023


reames added a comment.

I don't feel comfortable signing off on this as I don't know this part of code well enough, but I want to chime in with support for treating this like a regression.  If we can get a change merged into the release branch without compromising quality in other ways, I think we should.

Alex, on the code, can you explain why you took the approach of writing a new parser specifically for this case?  The existing routine has the IgnoreUnknown flag.  How does that differ from the semantics you need here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144353/new/

https://reviews.llvm.org/D144353



More information about the llvm-commits mailing list