[PATCH] D143437: [llvm] Use pointer index type for more GEP offsets (pre-codegen)

[Krzysztof Drewniak via Phabricator via llvm-commits]

krzysz00 added a comment.

@arsenm, I can try to put together tests for some of the remaining stuff (like the ICmp merge). However, unless I'm forgetting something, the remaaining untested bits are the ones that call accumulateConstantOffset(), which, per https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Operator.cpp#L94-L96 , will crash if you mix up pointer bitwidth and index bitwidth. I'm not sure that fixing up those crashes (when most of the other code in LLVM has been fixed for this) justifies a test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143437/new/

https://reviews.llvm.org/D143437