[PATCH] D144385: [PDB] Error on too large stream directories

[Alexandre Ganea via Phabricator via llvm-commits]

aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

Thanks for the changes!

I'm seeing that Zach added quite a few tests for MSF <https://github.com/llvm/llvm-project/blob/main/llvm/unittests/DebugInfo/MSF/MSFBuilderTest.cpp>, not sure if you had the time/if it's worth crafting a test for this.

Otherwise, looks good.



================
Comment at: lld/COFF/PDB.cpp:1695
+          if (me.isPageOverflow())
+            error("try setting a larger /pdbpagesize");
+        });
----------------
Just a nit: How does the errors look like in stderr? I wonder if we shouldn't use `joinErrors` to have both errors contiguous on a single line?


================
Comment at: llvm/lib/DebugInfo/MSF/MSFError.cpp:47
+    case msf_error_code::stream_directory_overflow:
+      return "PDB Stream directory too large.";
     }
----------------
s/Stream/stream/ to be consistent with the other messages.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144385/new/

https://reviews.llvm.org/D144385