[PATCH] D144571: [DAGCombine] Fix an ICE in combineMinNumMaxNum(...)

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally marked 4 inline comments as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/test/CodeGen/X86/2023-02-22-combineMinNumMaxNum.ll:21
+
+attributes #0 = { "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" }
----------------
arsenm wrote:
> Do we really need the attributes (IIRC, yes for this case which really should be fixed)
We do. Those are the requirements from `isLegalToCombineMinNumMaxNum(...)`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144571/new/

https://reviews.llvm.org/D144571