[PATCH] D143787: [X86] Add new pass `X86FixupInstTuning` for fixing up machine-instruction selection.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D143787#4144121 <https://reviews.llvm.org/D143787#4144121>, @RKSimon wrote:

> Probably better for this first patch to add the pass and the inital vpermilps -> vshufps/vshufd fold, the scheduler based unpckpd fold can be added in a followup

Done, version with sched info + unpck transform as at: D144570 <https://reviews.llvm.org/D144570>



================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:84
+    }
+    return 0.0;
+  };
----------------
RKSimon wrote:
> It'd be better to return Optional<double> instead of 0.0 for failed matches (and return nullopt here)
Done in new version: D144570



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143787/new/

https://reviews.llvm.org/D143787