[PATCH] D143052: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 22 09:09:07 PST 2023
phosek added a comment.
In D143052#4144613 <https://reviews.llvm.org/D143052#4144613>, @DavidSpickett wrote:
> Is the intention that we handle this like `CMakePolicy.cmake` and pull it from the source dir when we build flang, or is it a mistake to move it to the top level?
Yes that's the intention. I'm also fine reverting this change; after D144509 <https://reviews.llvm.org/D144509> lands which presumably will be soon, we should be able to just use `check_linker_flag` directly.
I suspect we'll want to use more common modules in the LLVM build in the future though so we'll need a better solution to avoid future such failures.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143052/new/
https://reviews.llvm.org/D143052
More information about the llvm-commits
mailing list