[PATCH] D144563: [SimplifyCFG] Improve the precision of `PtrValueMayBeModified`

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 08:34:52 PST 2023


jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/UnreachableEliminate.ll:476
 ;
 entry:
   br i1 %X, label %if, label %else
----------------
I'm worried because I didn't see a test with inbounds gep and `@fn_noundef_arg` call. 
`!GEP->hasAllZeroIndices()` does not imply non zero. It means we don't know it's all zero.
Can we make sure we don't accidentally read `poison` into the situation where it could as well be `null`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144563/new/

https://reviews.llvm.org/D144563



More information about the llvm-commits mailing list