[PATCH] D144566: [PatternMatch] Don't require DataLayout for m_VScale()

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 08:18:27 PST 2023


nikic created this revision.
nikic added reviewers: sdesmalen, david-arm, spatel.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The m_VScale() matcher is unusual in that it requires a DataLayout. It is currently used to determine the size of the GEP type. However, I believe it is sufficient to check for the canonical `<vscale x 1 x i8>` form here -- I don't think there's a need to recognize exotic variations like `<vscale x 1 x i4>` as a vscale constant representation as well.


https://reviews.llvm.org/D144566

Files:
  llvm/include/llvm/IR/PatternMatch.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/IR/IntrinsicInst.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
  llvm/unittests/IR/PatternMatch.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144566.499516.patch
Type: text/x-patch
Size: 5318 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230222/87d7241b/attachment.bin>


More information about the llvm-commits mailing list