[PATCH] D144562: [NFC] Refine tests by adding `:` to checks

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/MC/Hexagon/multiple-pc4.s:1
-# RUN: llvm-mc -arch=hexagon -filetype=asm %s 2>%t; FileCheck --implicit-check-not=error %s <%t
+# RUN: llvm-mc -arch=hexagon -filetype=asm %s 2>%t; FileCheck --implicit-check-not=error: %s <%t
 
----------------
Fznamznon wrote:
> jhenderson wrote:
> > Not related to your change, but does this line actually run FileCheck at all? I'm pretty sure it's missing a `|` character somewhere... Same goes with a few other tests you've modified.
> > 
> > (I am not familiar with these tests though, so my comment may be incorrect).
> I think it runs FileCheck. In this patch I modified only tests that were complaining about "error" substring in the path.
> I think the magic is hidden in combination of "2>%t" in llvm-mc command and following "<%t" in FileCheck command.
Ah, I compeltely misread that line, thanks! (The normal pattern is something like `2>&1 | FileCheck ...` without the `<%t` at the end, so I read the `2>%t;` bit as that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144562/new/

https://reviews.llvm.org/D144562