[PATCH] D144562: [NFC] Refine tests by adding `:` to checks

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 06:58:18 PST 2023


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but best leave it a bit in case others have comments.



================
Comment at: llvm/test/MC/Hexagon/multiple-pc4.s:1
-# RUN: llvm-mc -arch=hexagon -filetype=asm %s 2>%t; FileCheck --implicit-check-not=error %s <%t
+# RUN: llvm-mc -arch=hexagon -filetype=asm %s 2>%t; FileCheck --implicit-check-not=error: %s <%t
 
----------------
Not related to your change, but does this line actually run FileCheck at all? I'm pretty sure it's missing a `|` character somewhere... Same goes with a few other tests you've modified.

(I am not familiar with these tests though, so my comment may be incorrect).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144562/new/

https://reviews.llvm.org/D144562



More information about the llvm-commits mailing list