[PATCH] D144034: [AMDGPU][GFX11] Legalize and select partial NSA MIMG instructions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Missing verifier tests



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:5052
 
-    if (!UseNSA && Intr->NumVAddrs > 1)
+    if (UsePartialNSA)
+      convertImageAddrToPacked(B, MI, ArgOffset + Intr->VAddrStart,
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:4640-4642
+          unsigned LastVAddrIdx = SRsrcIdx - 1;
+          const TargetRegisterClass *RC = getOpRegClass(MI, LastVAddrIdx);
+          VAddrWords += RI.getRegSizeInBits(*RC) / 32 - 1;
----------------
Should use getOpSize


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144034/new/

https://reviews.llvm.org/D144034