[PATCH] D144070: [llvm][GenericUniformity] Prevent assert while calculating temporal divergence

Wed Feb 22 03:31:42 PST 2023

arsenm added inline comments.

================
Comment at: llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir:4
+--- |
+  define amdgpu_cs void @f2() #0 {
+  bb:
----------------
yassingh wrote:
> arsenm wrote:
> > yassingh wrote:
> > > arsenm wrote:
> > > > Shouldn't need IR section?
> > > I took the tests from [[ https://github.com/llvm/llvm-project/issues/60638 | #60638]] (extracted the GMIR input that was fed to uniformity analysis).  I wasn't able to use @llvm.amdgcn.raw.atomic.buffer.load without including the IR section. Is there a workaround? 
> > The intrinsic declaration is broken in some way because it's having an address computed. The reference in SI_PC_ADD_REL_OFFSET indicates this wasn't recognized as an intrinsic.
> I didn't realize earlier that @llvm.amdgcn.raw.atomic.buffer.load.i32 is not actually an intrinsic just looks like one, hence appears to be broken. 
> Considering dropping this test as it's confusing and bloated. 
This must have a test, but simpler 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144070/new/

https://reviews.llvm.org/D144070