[PATCH] D144532: [RISCV] Reorganize deinterleave lowering for reuse [nfc]

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 03:05:03 PST 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2937
+// Returns {Src Vector, Even Elements} om success
+static bool isDeinterleaveShuffle(MVT VT, MVT ContainerVT, SDValue V1,
+                                  SDValue V2, ArrayRef<int> Mask,
----------------
Is the "function of type SDValue that returns `SDValue()` on failure otherwise lower" style more idiomatic than "perform check with boolean function first then lower"?
If so I can update D144092 to use the former


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144532/new/

https://reviews.llvm.org/D144532



More information about the llvm-commits mailing list