[PATCH] D144442: [X86] Add tests for replacing `{v}unpck{l|h}pd` -> `{v}shufps`; NFC

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 23:33:44 PST 2023


goldstein.w.n added a comment.

In D144442#4143398 <https://reviews.llvm.org/D144442#4143398>, @RKSimon wrote:

> We might want to consider a naming convention to accommodate future cpu-tuning tests - how about tuning-shuffle-unpckpd.ll?

Agreed, changed in v2.



================
Comment at: llvm/test/CodeGen/X86/unpckpd-to-faster-alternative.ll:43
+; CHECK-NEXT:    retq
+; -LABEL: transform_VUNPCKLPDYrr:
+; :       # %bb.0:
----------------
RKSimon wrote:
> Cleanup?
What do you mean? Thats the output from
```
/home/noah/programs/opensource/llvm-dev/src/llvm-project/llvm/utils/update_llc_test_checks.py --llc-binary /home/noah/programs/opensource/llvm-dev/src/llvm-project/build/bin/llc /home/noah/programs/opensource/llvm-dev/src/llvm-project/llvm/test/CodeGen/X86/unpckpd-to-faster-alternative.ll
```

What command should I use?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144442/new/

https://reviews.llvm.org/D144442



More information about the llvm-commits mailing list