[PATCH] D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D134282#4141617 <https://reviews.llvm.org/D134282#4141617>, @Jake-Egan wrote:

> It fails with a different assembler error on different platforms (tried on AIX, linux, and mac). No error if you remove the AIX target.
>
>   clang++ -target powerpc64-ibm-aix -c foo.cc

@Jake-Egan,

I had to add `-O` before I got the bad assembly:

  clang++ -target powerpc64-ibm-aix -O -S -o - foo.cc

The bad assembly does not have the 1-byte element/1-byte alignment section defined, but it has the TOC entry for it:

          .toc
  L..C0:
          .tc .rodata.str1.1L...str[TC],.rodata.str1.1L...str[RO]
  L..C1:
          .tc .rodata.str1.8L...str[TC],.rodata.str1.8L...str[RO]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134282/new/

https://reviews.llvm.org/D134282