[PATCH] D143785: [X86] Add Extend shuffle pattern to vNf32 shuffles.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:17208
+static void computeInLaneShuffleMask(const ArrayRef<int> &Mask,
+                                     SmallVector<int, 32> *InLaneMaskOut) {
+  int Size = Mask.size();
----------------
RKSimon wrote:
> SmallVectorImpl<int> &InLaneMask
Any chance we can keep it as a pointer? imo output references are confusing as hell.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143785/new/

https://reviews.llvm.org/D143785