[PATCH] D142556: [DebugInfo] Merge partially matching chains of inlined locations

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Reckon this is worth a go - maybe wait for @aprantl to sign off too, though.



================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:155-157
+    // The + 1 is to account for the &*rev_it = &(it - 1) relationship.
+    ARIt = LocVec::reverse_iterator(ALocs.begin() + IT->second + 1);
+    BRIt = LocVec::reverse_iterator(BLocs.begin() + I + 1);
----------------
Would it be easier to express/read as arithmetic on rbegin, rather than begin->arithmetic->reverse?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142556/new/

https://reviews.llvm.org/D142556