[PATCH] D144471: [ELF] Prohibit icf=safe warning from being fatal

Tue Feb 21 11:17:20 PST 2023

melver abandoned this revision.
melver added a comment.

In D144471#4142299 <https://reviews.llvm.org/D144471#4142299>, @MaskRay wrote:

> I don't think we want more diagnostic levels. The warning is not fatal, it's just that some users use `--fatal-warnings` to upgrade warnings to errors.
> If this warning is annoying under `--fatal-warnings`, we can think of `message(...)`. But right now, it seems appropriate for the user to be aware of the problem and discard `.llvm_addrsig` by themselves.
> (I have more notes in https://maskray.me/blog/2020-11-15-explain-gnu-linker-options )

Thanks - I'll abandon this for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144471/new/

https://reviews.llvm.org/D144471