[PATCH] D144298: [Local][SimplifyCFG][GVN] Handle !nontemporal in combineMetadata

Daniel Woodworth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 10:59:02 PST 2023


dwoodwor-intel updated this revision to Diff 499237.
dwoodwor-intel retitled this revision from "[Local][SimplifyCFG] Handle !nontemporal in combineMetadata" to "[Local][SimplifyCFG][GVN] Handle !nontemporal in combineMetadata".
dwoodwor-intel added a comment.

I've added a new GVN test to exercise the `patchReplacementInstruction` change, and I also added a GVNSink test to make sure this change works properly in that pass too even though it uses the same code path as SimplifyCFG. Are there other passes I should add tests for/update to better combine !nontemporal metadata?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144298/new/

https://reviews.llvm.org/D144298

Files:
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/GVN/nontemporal.ll
  llvm/test/Transforms/GVNSink/sink-combine-metadata.ll
  llvm/test/Transforms/SimplifyCFG/X86/sink-common-code.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144298.499237.patch
Type: text/x-patch
Size: 4953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230221/6513478f/attachment.bin>


More information about the llvm-commits mailing list