[PATCH] D143887: [BOLT][AArch64] Replace NOP with adrp in AdrRelaxationPass to preserve relative offsets.

[Rafael Auler via Phabricator via llvm-commits]

rafauler added a comment.

Looks good to me, but who wrote this was @yota9. @yota9 can you take a look at these changes?



================
Comment at: bolt/test/runtime/AArch64/adrrelaxationpass.s:3
 # and must be replaced with ADRP + ADD by BOLT
+# Also since main is non-simple, we can't change it's length so we have to
+# replace NOP with adrp, and if there is no nop before adr in non-simple function,
----------------
nit: I think this file is 80column, can you format the text?


================
Comment at: bolt/test/runtime/AArch64/adrrelaxationpass.s:15
 # RUN: %t.bolt
-
+# RUN: not llvm-bolt %t.exe -o %t.bolt --adr-relaxation=true --strict 2>&1 | FileCheck %s --check-prefix CHECK-ERROR
   .data
----------------
nit: break command line for 80-column:


```
  # RUN: not llvm-bolt %t.exe -o %t.bolt --adr-relaxation=true --strict \
  # RUN:   2>&1 | FileCheck %s --check-prefix CHECK-ERROR
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143887/new/

https://reviews.llvm.org/D143887