[PATCH] D144470: [ARM] Remove redundant BTI instructions for table jumps
Oliver Stannard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 21 09:00:30 PST 2023
olista01 added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMBranchTargets.cpp:68
// LLVM does not consider basic blocks which are the targets of jump tables
// to be address-taken (the address can't escape anywhere else), but they are
----------------
This comment can be removed too.
================
Comment at: llvm/test/MC/AArch64/remove-redundant-bti.s:1
+; RUN: llc -O2 --march=aarch64 < %s | FileCheck %s
+
----------------
The filename for this should end in `.ll`, because it contains IR, not assembly.
================
Comment at: llvm/test/MC/AArch64/remove-redundant-bti.s:30
+
+; CHECK-LABEL: .LBB0_2:
+; CHECK-NOT: bti
----------------
These tests should also check the tbb/tbh/mov instructions which branch to these labels, to make sure that the two test cases are testing different was of implementing jump tables.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144470/new/
https://reviews.llvm.org/D144470
More information about the llvm-commits
mailing list