[PATCH] D144339: [TextAPI] Implement TBDv5 Writer
Cyndy Ishida via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 21 08:45:11 PST 2023
cishida added inline comments.
================
Comment at: llvm/lib/TextAPI/TextStub.cpp:887-892
handleSymbols(Exports, File->exports(), [](const Symbol *Symbol) {
return !Symbol->isReexported();
});
handleSymbols(Reexports, File->exports(), [](const Symbol *Symbol) {
return Symbol->isReexported();
});
----------------
ributzka wrote:
> cishida wrote:
> > ributzka wrote:
> > > This is the section of code that might need changes.
> > This is addressed in https://reviews.llvm.org/D144428 along with other related fixes.
> Shouldn't [[ https://reviews.llvm.org/D144428 | D144428 ]] go first then?
I made the patch on top of this one using the new InterfaceFile methods.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144339/new/
https://reviews.llvm.org/D144339
More information about the llvm-commits
mailing list