[PATCH] D143593: [InstCombine] Don't fold freeze poison when it's used in shufflevector

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I'm okay with this.



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3972
+        match(U, m_Shuffle(m_Specific(V), m_Value())))
+      return true;
+    else if (match(U, m_BitCast(m_Specific(V))) && isUsedWithinShuffleVector(U))
----------------
Just check `isa<ShuffleVectorInst>`? Odd to check for specific operands if we don't care which one it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143593/new/

https://reviews.llvm.org/D143593