[PATCH] D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types

[Michal Paszkowski via Phabricator via llvm-commits]

mpaszkowski added a comment.

There still remains a large number of LIT tests with pointers-to-opaque-structs representing OpenCL builtin types. I would suggest to do either one of these things in the next patch:

1. Leave these tests in the current form (with -opaque-pointers=0)
2. Convert the tests to use SPIR-V builtin types instead of OpenCL builtin types
3. Convert the LIT tests to OpenCL C end-to-end tests (using Clang and llc)

I think converting most of the tests to be based on SPIR-V builtin types (2) and only keeping a handful of tests using pointers-to-opaque-struct (1) to demonstrate compatibility with old IR makes most sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144494/new/

https://reviews.llvm.org/D144494