[PATCH] D143708: [RISCV] Support emulated TLS

Vitaly Cheptsov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 07:33:44 PST 2023


vit9696 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/emutls_generic.ll:54
+; RISCV_64-NOT:   __emutls_v.external_x:
+; RISCV_64:        .data{{$}}
+; RISCV_64:        .globl __emutls_v.external_y
----------------
jrtc27 wrote:
> vit9696 wrote:
> > jrtc27 wrote:
> > > Why does the lack of a suffix matter? Seems a bit odd to pick this specifically.
> > This is because for non-emutls symbols are generated in .data.symbolname sections.
> No they're not, real TLS symbols are in .tdata/.tbss
This is most likely target-specific then. This is what we observed with `-ffunction-sections -fdata-sections` on I *think* MIPS in the past. I am fine to drop this part though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143708/new/

https://reviews.llvm.org/D143708



More information about the llvm-commits mailing list