[PATCH] D143578: [VP] Add vp.powi and a pass for expanding vp.powi before DAG.
Yeting Kuo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 21 07:31:24 PST 2023
fakepaper56 marked an inline comment as done.
fakepaper56 added a comment.
In D143578#4140944 <https://reviews.llvm.org/D143578#4140944>, @frasercrmck wrote:
> I get that scalable-vector `llvm.powi` is different, but so would many other scalable-vector intrinsics if the target doesn't support that operation: `llvm.sin`, `llvm.cos`, etc. So would we have passes for each intrinsic? If not, `ExpandPowi` seems too restrictive in its scope.
>
> If we're supporting intrinsics, what about plain scalable-vector `add` on a target without scalable vectors, like x86?
I agree with you that only expanding powi is too restrictive. I think at least we should expand all the math function in a pass. But I don't have no idea that whether we should expand scalable operations for target without scalable vectors?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143578/new/
https://reviews.llvm.org/D143578
More information about the llvm-commits
mailing list