[PATCH] D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support

Tue Feb 21 03:54:57 PST 2023

amilendra marked 28 inline comments as done.
amilendra added inline comments.

================
Comment at: lld/test/ELF/arm-cmse-implib.s:9
+// RUN: ld.lld -Ttext=0x8000 --section-start .gnu.sgstubs=0x20000 -o %t2 --out-implib=%t2.lib --in-implib=%t1.lib --cmse-implib %t2.o
+// RUN: llvm-readelf -s %t2 %t2.lib | FileCheck %s --check-prefix=CHECK2
+// RUN: llvm-objdump -d %t2 | FileCheck %s --check-prefix=DISS2
----------------
MaskRay wrote:
> In addition, if you specify `-Map=%t.map`, lld will crash.
> In addition, if you specify `-Map=%t.map`, lld will crash.

This was due to the import library being added to the vector consisting of other object files. Now that the import library has its own vector this does not happen any more.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092