[PATCH] D142524: [flang][OpenMP] Add parser support for order clause

Tue Feb 21 03:35:46 PST 2023

kavitha-natarajan added inline comments.

================
Comment at: flang/test/Parser/omp-order-clause02.f90:1
+! RUN: not %flang_fc1 -fopenmp %s 2>&1 | FileCheck %s
+
----------------
kiranchandramohan wrote:
> Nit: Use test_errors.py for error tests.
test_errors.py and its modules are located in flang/test/Semantics/ directory. All the error tests in Parser directory are written this way. Do you think we should start using test_errors.py for all error tests? If so, we may have to relocate the scripts from Semantics directory. Please let me know your comments.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:2008
     VersionedClause<OMPC_Collapse>,
-    VersionedClause<OMPC_Order>,
+    VersionedClause<OMPC_Order>
   ];
----------------
kiranchandramohan wrote:
> Nit: Isn't this also 50?
Yes, will change it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142524/new/

https://reviews.llvm.org/D142524