[PATCH] D142524: [flang][OpenMP] Add parser support for order clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for your first patch in Flang and welcome.

Two Nit comments inline.



================
Comment at: flang/test/Parser/omp-order-clause02.f90:1
+! RUN: not %flang_fc1 -fopenmp %s 2>&1 | FileCheck %s
+
----------------
Nit: Use test_errors.py for error tests.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:2008
     VersionedClause<OMPC_Collapse>,
-    VersionedClause<OMPC_Order>,
+    VersionedClause<OMPC_Order>
   ];
----------------
Nit: Isn't this also 50?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142524/new/

https://reviews.llvm.org/D142524