[PATCH] D144248: [InstCombine] canonicalize urem as cmp+select (part 2)

Tue Feb 21 01:10:00 PST 2023

Allen abandoned this revision.
Allen added a comment.

In D144248#4140758 <https://reviews.llvm.org/D144248#4140758>, @nikic wrote:

> I see. It looks like this much is safe to do without causing any regressions: https://github.com/nikic/llvm-project/commit/37366dc6bc6d168f081510a603982802a6964221 The ones in simplifyBinaryIntrinsic() and foldICmpWithDominatingICmp() are completely redundant.
>
> The one in simplifySelectInst() is not redundant, because it uses a different context instruction: We would miss cases where we have `br i1 %c` followed by `select i1 %c`, because the comparison is not in the same block as the select. This is unfortunate...

Thanks for the quick resolution

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144248/new/

https://reviews.llvm.org/D144248