[PATCH] D143578: [VP] Add vp.powi and a pass for expanding vp.powi before DAG.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandPowi.cpp:114
+                              {ConstantFP::get(BaseTy, 1.), NewRes, Mask, EVL});
+  // FIXME: Use vp.icmp.
+  Value *PredicateSLT = getPredicateValue(C, CmpInst::ICMP_SLT);
----------------
old fixme?


================
Comment at: llvm/lib/CodeGen/ExpandPowi.cpp:132
+      // TODO: Also support llvm.powi.
+      if (II->getIntrinsicID() == Intrinsic::vp_powi) {
+        Replace.push_back(II);
----------------
Drop curly braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143578/new/

https://reviews.llvm.org/D143578