[PATCH] D143044: [InstCombine][NFC] Add tests pre-implementation of issue #54856

Mon Feb 20 18:45:08 PST 2023

jmciver added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/icmp-logical.ll:1775
+; ((X u< 0x8000000) & ((X & 0x60000000) != 0x60000000)) -> X u< 0x60000000
+define i1 @masked_icmps_mask_allzeros_bmask_notmixed_and_notallones_1(i32 %x) {
+; CHECK-LABEL: @masked_icmps_mask_allzeros_bmask_notmixed_and_notallones_1(
----------------
RKSimon wrote:
> Sequentially numbering test names for a fold isn't great - it'd be better to use the name to describe the specific pattern in more detail
Thanks for the input! I have attempted to improve the test names with pattern details.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143044/new/

https://reviews.llvm.org/D143044