[PATCH] D144282: [X86] Add tests for (or/and (icmp eq/ne A, C0), (icmp eq/ne A, C1)) where IsPow2(dif(C0, C1)); NFC

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 18:17:57 PST 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/CodeGen/X86/icmp-pow2-diff.ll:8
+; Intentional negative test.
+define <4 x i1> @andnot_eq_v4i32_fail_no_splat(<4 x i32> %x) nounwind {
+; AVX512-LABEL: andnot_eq_v4i32_fail_no_splat:
----------------
RKSimon wrote:
> It should be possible to add nonuniform support in the future though? So is this a fail or a todo?
You're right, will change "fail" -> "todo" for cases we should be able to handle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144282/new/

https://reviews.llvm.org/D144282



More information about the llvm-commits mailing list