[PATCH] D144439: [X86] Disable base pointer register when it is clobbered.

Mon Feb 20 17:05:00 PST 2023

LuoYuanke added inline comments.

================
Comment at: llvm/test/CodeGen/X86/i386-baseptr.ll:64
   %k = call i32 @helper()
   %a = alloca i32, align 128
   %b = alloca i32, i32 %k, align 4
----------------
LuoYuanke wrote:
> LuoYuanke wrote:
> > craig.topper wrote:
> > > Are we not satisfying the alignment for this alloca now?
> > From the test case, it seems satisfy, but I'm not quite sure about it.
> Read it again, it does not satisfy the alignment for this alloca now.
It seems difficult to satisfy both alignment and "base pointer register" clobber. Maybe user has to change the inline assembly to save/restore "esi" by him/herself. Should we report warning in assembly to indicate user that "esi" is reserved by compiler?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144439/new/

https://reviews.llvm.org/D144439