[PATCH] D144351: llvm-tblgen: Let each emitter self-contained

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni marked an inline comment as done.
chapuni added a comment.

In D144351#4139448 <https://reviews.llvm.org/D144351#4139448>, @myhsu wrote:

> In D144351#4138905 <https://reviews.llvm.org/D144351#4138905>, @chapuni wrote:
>
>> - Move decl of `EmitDecoder()`to TableGenBackends.h
>
> maybe a dumb question: why?

DisassemblerEmitter.cpp declares it as ad-hoc decl `extern`. Since I touched around it, I have moved it to other header.
I have taken TableGenBackends.h since I thought excessive to introduce a new header like DecoderEmitter.h.



================
Comment at: llvm/utils/TableGen/TableGenBackends.h:80
+struct Opt {
+  Opt(StringRef p, FnT fn, StringRef desc, bool isDefault = false) {
+    if (isDefault)
----------------
myhsu wrote:
> nit: I believe function argument names should be camel case starting with upper case letter.
I have followed CommandLine.h.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144351/new/

https://reviews.llvm.org/D144351