[PATCH] D142427: [ValueTracking] Add logic for tracking lowbit of (and/xor/or X, (add/sub X, Odd))

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 10:32:35 PST 2023


goldstein.w.n added a comment.

In D142427#4138229 <https://reviews.llvm.org/D142427#4138229>, @nikic wrote:

> It looks like the tests have coverage for the newly added or/xor with add cases -- but this patch also adds sub cases that don't have any corresponding test change? Either the sub cases should be dropped, or they should be tested.

Added new tests to cover all new cases. Removed some of the less useful existing tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142427/new/

https://reviews.llvm.org/D142427



More information about the llvm-commits mailing list