[PATCH] D144351: llvm-tblgen: Let each emitter self-contained

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

In D144351#4138905 <https://reviews.llvm.org/D144351#4138905>, @chapuni wrote:

> - Move decl of `EmitDecoder()`to TableGenBackends.h

maybe a dumb question: why?



================
Comment at: llvm/utils/TableGen/TableGenBackends.h:80
+struct Opt {
+  Opt(StringRef p, FnT fn, StringRef desc, bool isDefault = false) {
+    if (isDefault)
----------------
nit: I believe function argument names should be camel case starting with upper case letter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144351/new/

https://reviews.llvm.org/D144351