[PATCH] D144034: [AMDGPU][GFX11] Legalize and select partial NSA MIMG instructions

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin marked 4 inline comments as done.
mbrkusanin added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1863
+  const bool UseNSA =
+      NumVAddrRegs != 1 && (IsGFX11Plus ? NumVAddrDwords >= NumVAddrRegs
+                                        : NumVAddrDwords == NumVAddrRegs);
----------------
arsenm wrote:
> Add a comment to explain there's a limit on gfx11
Using hasPartialNSAEncoding now. Should I still add a comment?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4985
+  const unsigned NSAMaxSize = ST.getNSAMaxSize();
+  const bool IsGFX11Plus = AMDGPU::isGFX11Plus(ST);
+
----------------
arsenm wrote:
> Can you make the descriptive of the NSA behavior rather than check/refer to gfx11+?
Using new subtarget feature instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144034/new/

https://reviews.llvm.org/D144034