[PATCH] D144282: [X86] Add tests for (or/and (icmp eq/ne A, C0), (icmp eq/ne A, C1)) where IsPow2(dif(C0, C1)); NFC

Mon Feb 20 09:25:05 PST 2023

goldstein.w.n added a comment.

In D144282#4138051 <https://reviews.llvm.org/D144282#4138051>, @pengfei wrote:

> In D144282#4138035 <https://reviews.llvm.org/D144282#4138035>, @goldstein.w.n wrote:
>
>> In D144282#4137911 <https://reviews.llvm.org/D144282#4137911>, @pengfei wrote:
>>
>>> Can we add tests on demand? It looks to me there are tests neither touched by D144283 <https://reviews.llvm.org/D144283> nor D144284 <https://reviews.llvm.org/D144284>.
>>
>> There are some intentionally not touched tests `*fail*`. Would you prefer I drop some of them?
>
> Or otherwise adding comments to explain the intention.

Done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144282/new/

https://reviews.llvm.org/D144282