[PATCH] D143134: [AMDGPU][SDAG] attempt to custom legalize uaddo/usubo for long operands

[Alexander via Phabricator via llvm-commits]

alex-t added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:899
+      const TargetRegisterClass *RC = getOperandRegClass(*UI, UI.getOperandNo());
+      if(!RC && Subtarget->getRegisterInfo()->isSGPRClass(RC))
+        continue;
----------------
if (!RC) is "true" which means getOperandRegClass has returned NULL we've got to evaluate the second part of the condition and will call the SIRegisterInfo::isSGPRClass with nullptr? Shouldn't there be OR instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143134/new/

https://reviews.llvm.org/D143134